This repository has been archived by the owner on Jun 27, 2021. It is now read-only.
Updated readme to clarify binary naming convention #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
reviewed
Aug 7, 2020
| @@ -29,7 +29,7 @@ Installing the Provider | |||
|
|
|||
| ```sh | |||
| $ mkdir -p $HOME/.terraform.d/plugins | |||
| $ mv terraform-provider-gsuite $HOME/.terraform.d/plugins/terraform-provider-gsuite | |||
There was a problem hiding this comment.
We should alter the build output, otherwise it won't have a gsuite_vX.Y.Z here to copy
DeviaVir
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to readme to clarify that the provider binary should include the version number, as per the docs [1]. The binaries in the releases do follow this, but the readme may mislead some (eg. me) to believe that the file should be saved without the version, leading to Terraform errors that the required plugin cannot be found.
[1] https://www.terraform.io/docs/configuration/providers.html\#plugin-names-and-versions